Finish remainder of xPtankPool#562
Conversation
|
Apologies, the changes are a little messy because I didn't run the formatter on the last PR |
🆗 ✅+1624 bytes No Regressions 🎉Progress: 10📈 |
JoshSanch
left a comment
JoshSanch
left a comment
There was a problem hiding this comment.
Great work overall! I left a comment for discussion - can consider merging after that's addressed.
🆗 ✅+1624 bytes No Regressions 🎉Progress: 10📈 |
|
src/SB/Core/x/xPtankPool.cpp
Outdated
| if (it->dst_blend == front->dst_blend && | ||
| it->src_blend == front->src_blend && | ||
| ((it->flags ^ front->flags) & rpPTANKDFLAGPOSITION) == 0) | ||
| (!(it->flags ^ front->flags) & rpPTANKDFLAGPOSITION)) |
There was a problem hiding this comment.
It looks like this change has introduced a regression. It should read as follows to be logically equivalent:
!((it->flags ^ front->flags) & rpPTANKDFLAGPOSITION)There was a problem hiding this comment.
I got overly confident and didn't check the objdiff before pushing haha
🆗 ✅+1624 bytes No Regressions 🎉Progress: 10📈 |
2 participants
This gets all of xPtankPool to match at 100% with the exception of
create_ptank()which is having scheduling issues with floats.Changes included are:
init_groups(),create_ptanks(...),xPTankPoolSceneEnter(),xPTankPoolSceneExit(),ptank_pool::grab_block(...), andptank_pool::flush()ptank_contextwhich one of the functions excepted to be within the anonymous namespaceNUM_GROUPSin favor of already existing enum value: MAX_PGTxPtankPool.cppandxPtankPool.h