Docs: First draft of contribution guidelines#554
Conversation
|
Consider adding a clear definition of variable naming conventions. |
|
Candidate convention I'd like to add based on this commit: |
|
I'm adding this line - it's a bit arbitrary but it closely aligns with Heavy Iron's naming standards so I'd like to follow that: |
This comment was marked as off-topic.
This comment was marked as off-topic.
SquareMan
left a comment
There was a problem hiding this comment.
Mostly lgtm.
Feel free to ignore my last comment if you disagree.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Proposing to add: This is inspired by the existing _all_the_floats function, and proposed changes on #567. This is an artifact of the old build/match comparison tooling and is no longer necessary. It also adds clean-up work later for no long-term benefit. |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Going to merge for now - I invite anyone with any further thoughts to raise an issue or to start discussion in the community Discord. |
With all of the new contributors coming in lately, I'd like to take this moment to introduce some contribution guidelines to help folks make PRs that will be easy to review and merge into the project.
My goal with this document is to have an accessible list of expectations that contributors can reference ahead of time and allowing for in-depth conversations on guidelines to occur within pull requests when they infrequently occur.
- Josh