Conversation
|
🆗 ✅+1398 bytes No Regressions 🎉Progress: 15📈 |
src/SB/Game/zCameraTweak.cpp
Outdated
| { | ||
| return sCamPitch; | ||
| F32 tan = itan(pitch); | ||
| F32 unk = d * tan; |
There was a problem hiding this comment.
This operation is a trig function meant to calculate a vertical offset given an angle and an adjacent side d, which we can presume to be distance based on the symbol name.
A better name for unk, therefore, would be deltaH, since the code seems to be modifying the original height by this incremental value.
There was a problem hiding this comment.
Just updated this! Thanks for the explanation
🆗 ✅+1398 bytes No Regressions 🎉Progress: 15📈 |
* iTRC work + file cleanup * removed most of CheckResetButton * Big work to zMain * Another big update to zMainParseIni * Start zShrapnel (#553) * zShrapnel work * fix include * zCameraTweak: Progress (#552) * zCameraTweak: Progress for most functions * zCameraTweak: Implement zCameraTweakGlobal_Update and clang-format * zCameraTweak: Remove empty space and format * zCameraTweak: Better name for local * iTRC work + file cleanup * removed most of CheckResetButton * Big work to zMain * Another big update to zMainParseIni * MainParseINI update + cleanup * Review Fixes * Review Fixes 2 --------- Co-authored-by: energydrink02 <136357605+energydrink02@users.noreply.github.com> Co-authored-by: Sebastián Meljem <95201472+0x5abe@users.noreply.github.com>
2 participants
I don't really know if it's cause of float scheduling or if there are any mistakes in the implementations, but zCameraTweakGlobal_Add, zCameraTweakGlobal_Remove, zCameraTweakGlobal_Reset and zCameraTweakGlobal_Update are really messed up. Also some of the data in sdata2 isn't being generated. In any case, these 4 functions can be removed if the PR can only be merged with the stuff that is fully matching.