Skip to content

xCutscene: Partial/Full matches, cutsceneHackTable update#543

Merged
JoshSanch merged 4 commits intobfbbdecomp:mainfrom
energydrink02:cutscene
May 15, 2025
Merged

xCutscene: Partial/Full matches, cutsceneHackTable update#543
JoshSanch merged 4 commits intobfbbdecomp:mainfrom
energydrink02:cutscene

Conversation

@energydrink02
Copy link
Contributor

Implement xCutscene_Update, CutsceneShadowRender and xCutscene_SetSpeed. Fully match except for SetSpeed (register swap).

Update cutsceneHackTable in zCutsceneMgr

@github-actions
Copy link

🆗 ✅

+2834 bytes
🆗 Bot Rating: Amazing contribution, you are the decomp GOAT 🐐

No Regressions 🎉

Progress: 7

📈 main/SB/Core/x/xCutscene - .text +820 bytes -> 17.21%
main/SB/Game/zCutsceneMgr - .data +384 bytes -> 100.00%
📈 main/SB/Game/zCutsceneMgr - .rodata +1599 bytes -> 99.50%
📈 main/SB/Core/x/xCutscene - .sdata2 +31 bytes -> 37.50%
main/SB/Core/x/xCutscene - xCutscene_Update(xCutscene*, float) +512 bytes -> 100.00%
📈 main/SB/Core/x/xCutscene - xCutscene_SetSpeed(xCutscene*, float) +196 bytes -> 98.00%
main/SB/Core/x/xCutscene - CutsceneShadowRender(CutsceneShadowModel*) +112 bytes -> 100.00%

@github-actions
Copy link

🆗 ✅

+2834 bytes
🆗 Bot Rating: Amazing contribution, you are the decomp GOAT 🐐

No Regressions 🎉

Progress: 7

📈 main/SB/Core/x/xCutscene - .text +820 bytes -> 17.21%
main/SB/Game/zCutsceneMgr - .data +384 bytes -> 100.00%
📈 main/SB/Game/zCutsceneMgr - .rodata +1599 bytes -> 99.50%
📈 main/SB/Core/x/xCutscene - .sdata2 +31 bytes -> 37.50%
main/SB/Core/x/xCutscene - xCutscene_Update(xCutscene*, float) +512 bytes -> 100.00%
📈 main/SB/Core/x/xCutscene - xCutscene_SetSpeed(xCutscene*, float) +196 bytes -> 98.00%
main/SB/Core/x/xCutscene - CutsceneShadowRender(CutsceneShadowModel*) +112 bytes -> 100.00%

Copy link
Collaborator

@JoshSanch JoshSanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for your first contribution!

@JoshSanch JoshSanch merged commit bc069d1 into bfbbdecomp:main May 15, 2025
5 checks passed
@energydrink02 energydrink02 deleted the cutscene branch May 15, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants