Skip to content

xMath Progress#540

Merged
mattbruv merged 3 commits intobfbbdecomp:mainfrom
daft7:40push2
May 14, 2025
Merged

xMath Progress#540
mattbruv merged 3 commits intobfbbdecomp:mainfrom
daft7:40push2

Conversation

@daft7
Copy link
Contributor

@daft7 daft7 commented May 14, 2025

Partial matches for xMathSolveCubic, xAccelMove, xAccelStop, and an overload of xAccelMove. Some temp variables trimmed out but still some left.

@github-actions
Copy link

⚠️ 🔥

+1764 bytes
🆗 Bot Rating: A fantastic contribution! ✨🎉

Regressions: 35

⚠️ main/SB/Core/x/xHudMeter - .data -40 bytes -> 0.00%
⚠️ main/SB/Core/x/xHudMeter - .rodata -48 bytes -> 0.00%
⚠️ main/SB/Core/x/xHudMeter - .sbss -8 bytes -> 0.00%
⚠️ main/SB/Core/x/xHudMeter - .sdata2 -50 bytes -> 0.00%
⚠️ main/SB/Core/x/xHudMeter - .text -1156 bytes -> 0.00%
⚠️ main/SB/Core/x/xHudMeter - .text -16 bytes -> 0.00%
⚠️ main/SB/Core/x/xHudMeter - .text -16 bytes -> 0.00%
⚠️ main/SB/Core/x/xHudMeter - .text -32 bytes -> 0.00%
⚠️ main/SB/Game/zCamera - .sdata2 -50 bytes -> 55.84%
⚠️ main/SB/Game/zCamera - .text -55 bytes -> 49.51%
⚠️ main/SB/Core/gc/ngcrad3d - .bss -40 bytes -> 0.00%
⚠️ main/SB/Core/gc/ngcrad3d - .sbss -8 bytes -> 0.00%
⚠️ main/SB/Core/gc/ngcrad3d - .sdata2 -30 bytes -> 0.00%
⚠️ main/SB/Core/gc/ngcrad3d - .text -500 bytes -> 0.00%
⚠️ main/SB/Core/x/xHudMeter - xhud::@unnamed@xHudMeter_cpp@::add_global_tweaks() -4 bytes -> 0.00%
⚠️ main/SB/Core/x/xHudMeter - xhud::meter_widget::set_value(float) -276 bytes -> 0.00%
⚠️ main/SB/Core/x/xHudMeter - xhud::meter_widget::set_value_immediate(float) -20 bytes -> 0.00%
⚠️ main/SB/Core/x/xHudMeter - xhud::meter_widget::meter_widget(const xhud::meter_asset&) -132 bytes -> 0.00%
⚠️ main/SB/Core/x/xHudMeter - xhud::meter_widget::destruct() -32 bytes -> 0.00%
⚠️ main/SB/Core/x/xHudMeter - xhud::meter_widget::type() const -56 bytes -> 0.00%
⚠️ main/SB/Core/x/xHudMeter - xhud::meter_widget::is(unsigned int) const -104 bytes -> 0.00%
⚠️ main/SB/Core/x/xHudMeter - xhud::meter_widget::updater(float) -532 bytes -> 0.00%
⚠️ main/SB/Core/x/xHudMeter - sound_queue<4>::sound_queue() -16 bytes -> 0.00%
⚠️ main/SB/Core/x/xHudMeter - xhud::meter_asset::type_name() -16 bytes -> 0.00%
⚠️ main/SB/Core/x/xHudMeter - xhud::meter_widget::update(float) -32 bytes -> 0.00%
⚠️ main/SB/Game/zCamera - zCameraReset(xCamera*) -4 bytes -> 70.97%
⚠️ main/SB/Game/zCamera - zCameraUpdate(xCamera*, float) -84 bytes -> 0.00%
⚠️ main/SB/Core/gc/ngcrad3d - Open_RAD_3D_image -232 bytes -> 0.00%
⚠️ main/SB/Core/gc/ngcrad3d - Close_RAD_3D_image -76 bytes -> 0.00%
⚠️ main/SB/Core/gc/ngcrad3d - Lock_RAD_3D_image -80 bytes -> 0.00%
⚠️ main/SB/Core/gc/ngcrad3d - Unlock_RAD_3D_image -48 bytes -> 0.00%
⚠️ main/SB/Core/gc/ngcrad3d - GXEnd -4 bytes -> 0.00%
⚠️ main/SB/Core/gc/ngcrad3d - GXTexCoord2f32 -16 bytes -> 0.00%
⚠️ main/SB/Core/gc/ngcrad3d - GXColor4u8 -24 bytes -> 0.00%
⚠️ main/SB/Core/gc/ngcrad3d - GXPosition3s16 -20 bytes -> 0.00%

Progress: 7

📈 main/SB/Core/x/xMath - .text +1712 bytes -> 76.75%
📈 main/SB/Core/x/xMath - .sdata2 +20 bytes -> 62.75%
main/SB/Game/zCamera - zCameraFreeLookSetGoals(xCamera*, float, float&, float&, float&, float&, float) +32 bytes -> 100.00%
📈 main/SB/Core/x/xMath - xAccelMove(float&, float&, float, float, float, float) +632 bytes -> 86.81%
main/SB/Core/x/xMath - xMathSolveCubic(float, float, float, float, float*, float*, float*) +676 bytes -> 100.00%
📈 main/SB/Core/x/xMath - xAccelStop(float&, float&, float, float) +168 bytes -> 64.62%
main/SB/Core/x/xMath - xAccelMove(float&, float&, float, float, float) +236 bytes -> 100.00%

@mattbruv mattbruv merged commit fa706dc into bfbbdecomp:main May 14, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants