setup all ::create functions in zNPCTypeDutchman by LivewireCB · Pull Request #535 · bfbbdecomp/bfbb

LivewireCB · 2025-05-10T02:53:31Z

Will work on more actual functions tmr. Wanted to finish these.

github-actions · 2025-05-10T02:54:54Z

🆗 ✅

+2069 bytes
🆗 Bot Rating: Amazing contribution, you are the decomp GOAT 🐐

No Regressions 🎉

Progress: 26

📈 main/SB/Game/zNPCTypeDutchman - .text +1212 bytes -> 14.54%
📈 main/SB/Game/zNPCTypeDutchman - .text +760 bytes -> 55.20%
📈 main/SB/Game/zNPCTypeDutchman - .data +97 bytes -> 74.28%
📈 main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanCaught::Enter(float, void*) +16 bytes -> 11.43%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanInitiate::create(int, RyzMemGrow*, void*) +112 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanIdle::create(int, RyzMemGrow*, void*) +112 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanTeleport::create(int, RyzMemGrow*, void*) +112 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanReappear::create(int, RyzMemGrow*, void*) +112 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanBeam::create(int, RyzMemGrow*, void*) +112 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanFlame::create(int, RyzMemGrow*, void*) +112 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanPostFlame::create(int, RyzMemGrow*, void*) +112 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanCaught::create(int, RyzMemGrow*, void*) +112 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanDamage::create(int, RyzMemGrow*, void*) +112 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanDeath::create(int, RyzMemGrow*, void*) +112 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanInitiate::zNPCGoalDutchmanInitiate(int, zNPCDutchman&) +76 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanIdle::zNPCGoalDutchmanIdle(int, zNPCDutchman&) +76 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanTeleport::zNPCGoalDutchmanTeleport(int, zNPCDutchman&) +76 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanReappear::zNPCGoalDutchmanReappear(int, zNPCDutchman&) +76 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanBeam::zNPCGoalDutchmanBeam(int, zNPCDutchman&) +76 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanFlame::zNPCGoalDutchmanFlame(int, zNPCDutchman&) +76 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanPostFlame::zNPCGoalDutchmanPostFlame(int, zNPCDutchman&) +76 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanCaught::zNPCGoalDutchmanCaught(int, zNPCDutchman&) +76 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanDamage::zNPCGoalDutchmanDamage(int, zNPCDutchman&) +76 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanDeath::zNPCGoalDutchmanDeath(int, zNPCDutchman&) +76 bytes -> 100.00%
📈 main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanInitiate::Exit(float, void*) +32 bytes -> 61.54%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanPostFlame::Exit(float, void*) +44 bytes -> 100.00%

JoshSanch · 2025-05-10T02:58:25Z

src/SB/Game/zNPCTypeDutchman.cpp

+S32 zNPCGoalDutchmanInitiate::Exit(F32 dt, void* updCtxt)
+{
+return xGoal::Exit(dt, updCtxt);
+}


Nitpick: This formatting is off if you could fix it.

JoshSanch · 2025-05-10T02:59:20Z

src/SB/Game/zNPCTypeDutchman.cpp

+S32 zNPCGoalDutchmanCaught::Enter(float dt, void* updCtxt)
+{
+    // To-Do
+    return zNPCGoalCommon::Enter(dt, updCtxt);
+}


Nitpick: Use the standard // TODO notation that most IDEs scan for

github-actions · 2025-05-10T03:01:33Z

🆗 ✅

+2069 bytes
🆗 Bot Rating: Amazing contribution, you are the decomp GOAT 🐐

No Regressions 🎉

Progress: 26

📈 main/SB/Game/zNPCTypeDutchman - .text +1212 bytes -> 14.54%
📈 main/SB/Game/zNPCTypeDutchman - .text +760 bytes -> 55.20%
📈 main/SB/Game/zNPCTypeDutchman - .data +97 bytes -> 74.28%
📈 main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanCaught::Enter(float, void*) +16 bytes -> 11.43%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanInitiate::create(int, RyzMemGrow*, void*) +112 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanIdle::create(int, RyzMemGrow*, void*) +112 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanTeleport::create(int, RyzMemGrow*, void*) +112 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanReappear::create(int, RyzMemGrow*, void*) +112 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanBeam::create(int, RyzMemGrow*, void*) +112 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanFlame::create(int, RyzMemGrow*, void*) +112 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanPostFlame::create(int, RyzMemGrow*, void*) +112 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanCaught::create(int, RyzMemGrow*, void*) +112 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanDamage::create(int, RyzMemGrow*, void*) +112 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanDeath::create(int, RyzMemGrow*, void*) +112 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanInitiate::zNPCGoalDutchmanInitiate(int, zNPCDutchman&) +76 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanIdle::zNPCGoalDutchmanIdle(int, zNPCDutchman&) +76 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanTeleport::zNPCGoalDutchmanTeleport(int, zNPCDutchman&) +76 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanReappear::zNPCGoalDutchmanReappear(int, zNPCDutchman&) +76 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanBeam::zNPCGoalDutchmanBeam(int, zNPCDutchman&) +76 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanFlame::zNPCGoalDutchmanFlame(int, zNPCDutchman&) +76 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanPostFlame::zNPCGoalDutchmanPostFlame(int, zNPCDutchman&) +76 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanCaught::zNPCGoalDutchmanCaught(int, zNPCDutchman&) +76 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanDamage::zNPCGoalDutchmanDamage(int, zNPCDutchman&) +76 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanDeath::zNPCGoalDutchmanDeath(int, zNPCDutchman&) +76 bytes -> 100.00%
📈 main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanInitiate::Exit(float, void*) +32 bytes -> 61.54%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanPostFlame::Exit(float, void*) +44 bytes -> 100.00%

github-actions · 2025-05-10T03:04:41Z

🆗 ✅

+2069 bytes
🆗 Bot Rating: Amazing contribution, you are the decomp GOAT 🐐

No Regressions 🎉

Progress: 26

📈 main/SB/Game/zNPCTypeDutchman - .text +1212 bytes -> 14.54%
📈 main/SB/Game/zNPCTypeDutchman - .text +760 bytes -> 55.20%
📈 main/SB/Game/zNPCTypeDutchman - .data +97 bytes -> 74.28%
📈 main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanCaught::Enter(float, void*) +16 bytes -> 11.43%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanInitiate::create(int, RyzMemGrow*, void*) +112 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanIdle::create(int, RyzMemGrow*, void*) +112 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanTeleport::create(int, RyzMemGrow*, void*) +112 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanReappear::create(int, RyzMemGrow*, void*) +112 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanBeam::create(int, RyzMemGrow*, void*) +112 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanFlame::create(int, RyzMemGrow*, void*) +112 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanPostFlame::create(int, RyzMemGrow*, void*) +112 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanCaught::create(int, RyzMemGrow*, void*) +112 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanDamage::create(int, RyzMemGrow*, void*) +112 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanDeath::create(int, RyzMemGrow*, void*) +112 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanInitiate::zNPCGoalDutchmanInitiate(int, zNPCDutchman&) +76 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanIdle::zNPCGoalDutchmanIdle(int, zNPCDutchman&) +76 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanTeleport::zNPCGoalDutchmanTeleport(int, zNPCDutchman&) +76 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanReappear::zNPCGoalDutchmanReappear(int, zNPCDutchman&) +76 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanBeam::zNPCGoalDutchmanBeam(int, zNPCDutchman&) +76 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanFlame::zNPCGoalDutchmanFlame(int, zNPCDutchman&) +76 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanPostFlame::zNPCGoalDutchmanPostFlame(int, zNPCDutchman&) +76 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanCaught::zNPCGoalDutchmanCaught(int, zNPCDutchman&) +76 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanDamage::zNPCGoalDutchmanDamage(int, zNPCDutchman&) +76 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanDeath::zNPCGoalDutchmanDeath(int, zNPCDutchman&) +76 bytes -> 100.00%
📈 main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanInitiate::Exit(float, void*) +32 bytes -> 61.54%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanPostFlame::Exit(float, void*) +44 bytes -> 100.00%

setup all ::create functions in zNPCTypeDutchman

50e79e6

JoshSanch reviewed May 10, 2025

View reviewed changes

formatting fix

8534675

todo format fix

d22e76c

JoshSanch approved these changes May 10, 2025

View reviewed changes

JoshSanch merged commit 956129b into bfbbdecomp:main May 10, 2025
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

setup all ::create functions in zNPCTypeDutchman#535

setup all ::create functions in zNPCTypeDutchman#535
JoshSanch merged 3 commits intobfbbdecomp:mainfrom
LivewireCB:dev

LivewireCB commented May 10, 2025

Uh oh!

github-actions bot commented May 10, 2025

Uh oh!

JoshSanch May 10, 2025

Uh oh!

LivewireCB May 10, 2025

Uh oh!

JoshSanch May 10, 2025

Uh oh!

github-actions bot commented May 10, 2025

Uh oh!

github-actions bot commented May 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

LivewireCB commented May 10, 2025

Uh oh!

github-actions bot commented May 10, 2025

🆗 ✅

No Regressions 🎉

Progress: 26

Uh oh!

JoshSanch May 10, 2025

Choose a reason for hiding this comment

Uh oh!

LivewireCB May 10, 2025

Choose a reason for hiding this comment

Uh oh!

JoshSanch May 10, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented May 10, 2025

🆗 ✅

No Regressions 🎉

Progress: 26

Uh oh!

github-actions bot commented May 10, 2025

🆗 ✅

No Regressions 🎉

Progress: 26

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants