Skip to content

xCM work#520

Merged
mattbruv merged 1 commit intobfbbdecomp:mainfrom
escape209:xcm
Apr 17, 2025
Merged

xCM work#520
mattbruv merged 1 commit intobfbbdecomp:mainfrom
escape209:xcm

Conversation

@escape209
Copy link
Contributor

let it be known that xCMprep was a bitch

@github-actions
Copy link

⚠️ 🔥

+462 bytes
🆗 Bot Rating: A decent contribution. Thank you!

Regressions: 22

⚠️ main/SB/Game/zTalkBox - .text -16 bytes -> 0.00%
⚠️ main/SB/Game/zNPCFXCinematic - .rodata -441 bytes -> 0.00%
⚠️ main/SB/Game/zNPCFXCinematic - .sdata2 -38 bytes -> 0.00%
⚠️ main/SB/Game/zNPCFXCinematic - .text -2844 bytes -> 0.05%
⚠️ main/SB/Game/zTalkBox - ztalkbox::get_active() -16 bytes -> 0.00%
⚠️ main/SB/Game/zNPCFXCinematic - NCIN_Par_BPLANK_JET_1_Upd(const zCutsceneMgr*, NCINEntry*, int) -204 bytes -> 0.00%
⚠️ main/SB/Game/zNPCFXCinematic - NCIN_Par_BPLANK_JET_2_Upd(const zCutsceneMgr*, NCINEntry*, int) -208 bytes -> 0.00%
⚠️ main/SB/Game/zNPCFXCinematic - NCIN_Par_BPLANK_SBB_FLAMES_1_Upd(const zCutsceneMgr*, NCINEntry*, int) -208 bytes -> 0.00%
⚠️ main/SB/Game/zNPCFXCinematic - NCIN_Par_BPLANK_SBB_FLAMES_2_Upd(const zCutsceneMgr*, NCINEntry*, int) -208 bytes -> 0.00%
⚠️ main/SB/Game/zNPCFXCinematic - NCIN_Par_BPLANK_SBB_JET_1_Upd(const zCutsceneMgr*, NCINEntry*, int) -208 bytes -> 0.00%
⚠️ main/SB/Game/zNPCFXCinematic - NCIN_Par_BPLANK_SBB_JET_2_Upd(const zCutsceneMgr*, NCINEntry*, int) -208 bytes -> 0.00%
⚠️ main/SB/Game/zNPCFXCinematic - NCIN_Par_BPLANK_SBB_SMOKE_1_Upd(const zCutsceneMgr*, NCINEntry*, int) -208 bytes -> 0.00%
⚠️ main/SB/Game/zNPCFXCinematic - NCIN_Par_BPLANK_SBB_SMOKE_2_Upd(const zCutsceneMgr*, NCINEntry*, int) -208 bytes -> 0.00%
⚠️ main/SB/Game/zNPCFXCinematic - NCIN_Par_CIN_BIGDUP_SMOKE_Upd(const zCutsceneMgr*, NCINEntry*, int) -208 bytes -> 0.00%
⚠️ main/SB/Game/zNPCFXCinematic - NCIN_Par_CIN_BIGDUP_SPAWN_Upd(const zCutsceneMgr*, NCINEntry*, int) -204 bytes -> 0.00%
⚠️ main/SB/Game/zNPCFXCinematic - NCIN_Par_CIN_PLATFORM_JETS_Upd(const zCutsceneMgr*, NCINEntry*, int) -204 bytes -> 0.00%
⚠️ main/SB/Game/zNPCFXCinematic - NCIN_Generic_Upd(const zCutsceneMgr*, NCINEntry*, int) -24 bytes -> 0.00%
⚠️ main/SB/Game/zNPCFXCinematic - NCIN_BubSlam(const zCutsceneMgr*, NCINEntry*, int) -128 bytes -> 0.00%
⚠️ main/SB/Game/zNPCFXCinematic - NCIN_BubTrailBone_AR(const zCutsceneMgr*, NCINEntry*, RpAtomic*, RwMatrixTag*, unsigned int, unsigned int) -108 bytes -> 0.00%
⚠️ main/SB/Game/zNPCFXCinematic - NCIN_BubHit(const zCutsceneMgr*, NCINEntry*, int) -100 bytes -> 0.00%
⚠️ main/SB/Game/zNPCFXCinematic - NCIN_Zapper(const zCutsceneMgr*, NCINEntry*, int) -112 bytes -> 0.00%
⚠️ main/SB/Game/zNPCFXCinematic - NCIN_HammerShock(const zCutsceneMgr*, NCINEntry*, int) -96 bytes -> 0.00%

Progress: 8

📈 main/SB/Core/x/xCM - .text +440 bytes -> 20.00%
📈 main/SB/Core/x/xCM - .sdata2 +14 bytes -> 36.36%
main/SB/Core/x/xCM - .sbss +8 bytes -> 100.00%
main/SB/Core/x/xCM - xCMprep(xCreditsData*) +240 bytes -> 100.00%
main/SB/Core/x/xCM - xCMupdate(float) +80 bytes -> 100.00%
📈 main/SB/Core/x/xCM - xCMstop() +40 bytes -> 62.50%
main/SB/Core/x/xCM - xCMrender() +40 bytes -> 100.00%
main/SB/Core/x/xCM - xCMstart(xCreditsData*, float, xBase*) +40 bytes -> 100.00%

@mattbruv mattbruv merged commit cc7bcc0 into bfbbdecomp:main Apr 17, 2025
5 checks passed
JoshSanch added a commit that referenced this pull request May 8, 2025
* ship it, YOLO

* test

* BossSB2 functions and mem offsets

* wip push

* push fix

* couple of bossplankton functions.

* znpcmessenger function fix

* More xMath3 work (#513)

* More xMath3 work

* This isnt matching

* Update 🆗 bot

* zNPCGoalAmbient: zNPCGoalJellyBumped Near 100% Match (#514)

* zNPCTypeCommon: Add declaration for zNPCCommon::HaveLOSToPos

* zNPCTypeAmbient: Add declarations for zNPCJellly ActLikeOctopus and JellyBoneWorldPos

* zFX: Add overload declarations for zFX_SpawnBubbleTrail

* xFX: Add overload declaration for xFXStreakUpdate

* zNPCGoalAmbient: Nearly 100% match for all zNPCGoalJellyBumped functions

* zNPCGoalAmbient: Fix flipped registers in CalcEndPoint implementation

* Robo-Sandy: Function Progress (#515)

* zNPCTypeVillager: Limit scope of g_sndTrax_Villager

* zNPCTypeBossSandy: Add SandyLimbSpring struct from DWARF data

* zNPCTypeBossSandy: Unextern floats and match most data

* Sandy: Several function matches + some WIP

* Sandy: Fix regression in ZNPC_AnimTable_BossSandy and increase matchingness

* zNPCFXCinematic -> NPARMgmt::KillAll() 100% (#516)

* Fix zNPCFXCinematic implementation

* All NPCCone functions 100%

* forgot one change.

* Moved Static S32 init to the top of file in zNPCFXCinematic.cpp

* Removed commented code in zNPCFXCinematic.cpp

* Removed commented code at the bottom of zNPCFXCinematic.cpp

* Removed commented code at the top of zNPCFXCinematic.h

* Added parameter names for UVSliceSet, UVBaseSet, ColorSet

* Removed the blank git file

* xSnd work (#517)

* 40% - 92% for some NCIN_Par functions in zNPCFXCinematic (#518)

* Fix zNPCFXCinematic implementation

* All NPCCone functions 100%

* forgot one change.

* Moved Static S32 init to the top of file in zNPCFXCinematic.cpp

* Removed commented code in zNPCFXCinematic.cpp

* Removed commented code at the bottom of zNPCFXCinematic.cpp

* Removed commented code at the top of zNPCFXCinematic.h

* Added parameter names for UVSliceSet, UVBaseSet, ColorSet

* Removed the blank git file

* 40% - 92% for some NCIN_Par functions in zNPCFXCinematic

* Pointer name fixes for NCIN_Par functions in zNPCFXCinematic + one 100% zTalkBox function

* Deleted static variables top of script

* xCM work (#520)

* Robo-Sandy Callback Funcs and Idle Goal Impl (#521)

* zNPCTypeBossSandy: Add SandyLimbSpring struct from DWARF data

* zNPCTypeBossSandy: sit, getUp, runToRope, clothesline callbacks

* zNPCTypeBossSandy: zNPCGoalBossSandyIdle virtual implementations

* Fix: Remove redef of SandyLimbSpring bc rebasing is hard

* Working more on zNPCFXCinematic with one 100% and started on other functions (#519)

* Fix zNPCFXCinematic implementation

* All NPCCone functions 100%

* forgot one change.

* Moved Static S32 init to the top of file in zNPCFXCinematic.cpp

* Removed commented code in zNPCFXCinematic.cpp

* Removed commented code at the bottom of zNPCFXCinematic.cpp

* Removed commented code at the top of zNPCFXCinematic.h

* Added parameter names for UVSliceSet, UVBaseSet, ColorSet

* Removed the blank git file

* 40% - 92% for some NCIN_Par functions in zNPCFXCinematic

* Pointer name fixes for NCIN_Par functions in zNPCFXCinematic + one 100% zTalkBox function

* Deleted static variables top of script

* Working more on zNPCFXCinematic with one 100% and started some others.

* Working more on zNPCFXCinematic with one 100% and started some others.

* Fixed a minor error in zNPCFXCinematic

* Fixed a minor error in zTalkBox

* Fixed another minor error in zTalkBox

* Fixed formatting and removed a zTalkBox function

* Match most of iMix (#522)

* Match most of iMix

* Correct MIXUnMute signature

* Hack around not being able to use _AXVPB. Having issues including it for some reason.

* Robosandy: Progress (#523)

* zNPCTypeBossSandy: Add SandyLimbSpring struct from DWARF data

* Fix: Remove redef of SandyLimbSpring bc rebasing is hard

* zNPCTypeBossSandy: Taunt, Chase, and Melee goal virtual method impls

* zNPCTypeBossSandy: NoHead Goal Enter match, Process WIP

* zEntHangable progress (#524)

* first fn

* save

* moreo prrogress

* static vars

* hangable_reset

* setfollow

* setupfx

* stub fns

* cleanup

* fix build

* zCamera: 95% match on zCameraFlyUpdate (#525)

* zNPCSupplement work (#526)

* zCamera: Equiv/Near Equiv for more functions (#527)

* zNPCSupport work (#528)

* zCamera: zCameraFlyRestoreBackup and zCameraRewardUpdate functions (#529)

* zNPCSpawner: Matches and additional function definitions (#530)

* zNPCSpawner: Matches and additional function definitions

* Config: Use more VS Code-friendly settings

* Little bit of zNPCtypeBossPlankton

---------

Co-authored-by: Matt P <mattp3259@gmail.com>
Co-authored-by: escape209 <agtescape@gmail.com>
Co-authored-by: mattbruv <5638426+mattbruv@users.noreply.github.com>
Co-authored-by: Joshua Sanchez <joshuaesanch@gmail.com>
Co-authored-by: Red <53205920+Redberd36@users.noreply.github.com>
@escape209 escape209 deleted the xcm branch July 22, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants