Update Github CI to Treat Warnings as Errors and Check Non-Matching Files for Errors#482
Merged
SquareMan merged 7 commits intobfbbdecomp:mainfrom Mar 28, 2025
Merged
Update Github CI to Treat Warnings as Errors and Check Non-Matching Files for Errors#482SquareMan merged 7 commits intobfbbdecomp:mainfrom
SquareMan merged 7 commits intobfbbdecomp:mainfrom
Conversation
…ing files compile/link without issue
SquareMan
reviewed
Mar 27, 2025
SquareMan
requested changes
Mar 27, 2025
Member
SquareMan
left a comment
SquareMan
left a comment
There was a problem hiding this comment.
Looking at the output I'm pretty sure it's not actually building. We may have to delete the existing binary to get it to rebuild.
Member
|
CI looks good now. Do you think you'd be able to fix the linker error now? Some data just needs to be moved from a header to the proper cpp file. I can also go ahead and merge anyway and fix it in a followup. |
Collaborator
Author
|
I'd like to fix it before we merge - currently working on fixing the linker errors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a couple of warnings that were preventing builds from succeeding as a result of the build flag changes.