Add full headers for dolsdk2004#409
Merged
JoshSanch merged 3 commits intobfbbdecomp:mainfrom Mar 29, 2025
Merged
Conversation
Merged
Collaborator
|
We are merging this PR in, acknowledging that these headers will be an inexact match for this project. However, they will be closer to what we need than what we have now, so the progress is welcome. Thanks for the effort @SquareMan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically just the full set of headers from doldecomp/dolsdk2004
This may not be 100% accurate for us but I figure that we will need to edit these headers much less often than we currently need to edit our monolithic dolphin.h
Notable Changes:
fastmath.h
Starting getting a redefinition error for
Vecin xVec3.cpp for some reason after this. It appears to be unused so I just deleted it from the fastmath header.dolphin/types.h
adjusted std includes to use our std headers.
dolphin/card.h
renamed two function arguments from
newto_newto avoid conflicting with the c++ keywordAdded missing defines: