zEntSimpleObj - Most Functions to 100% Code Match#401
Merged
mattbruv merged 7 commits intobfbbdecomp:mainfrom Feb 11, 2025
Merged
zEntSimpleObj - Most Functions to 100% Code Match#401mattbruv merged 7 commits intobfbbdecomp:mainfrom
mattbruv merged 7 commits intobfbbdecomp:mainfrom
Conversation
Thank u Square
SquareMan
requested changes
Feb 10, 2025
| xModelInstance* destroyModel; | ||
| xModelInstance* hitModel; | ||
|
|
||
| zEntInit((zEnt*)ent, asset, 0x44535452U); |
Member
There was a problem hiding this comment.
this int literal should be a multicharacter literal.
zEntInit((zEnt*)ent, asset, 'DSTR'); I think.
| var_r29_2 = temp_r27; | ||
| var_r30_2 = 0U; | ||
| var_r25_2 = sMgrList; | ||
| // while (var_r30_2 < var_r26) |
Member
There was a problem hiding this comment.
What's all this code? Is this function WIP? No change needed if that's the case but I just want to make sure this isn't something you forgot to delete.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mgr functions are tough - will revisit those at a later time.