Skip to content

Update#10

Open
bezata wants to merge 256 commits intoexperimentalfrom
main
Open

Update#10
bezata wants to merge 256 commits intoexperimentalfrom
main

Conversation

@bezata
Copy link
Copy Markdown
Owner

@bezata bezata commented Jun 1, 2024

No description provided.

dcselek and others added 30 commits April 8, 2024 23:41
Description:
This pull request introduces a refactor to the Dialog component and its related components to use React context for passing the setOpen function. This change addresses the issue where TypeScript was complaining about the setOpen prop not being a part of the DialogPrimitive.Content component's props.

Changes:
Created a Dialog Context:

Added a new DialogContext to hold the setOpen function.
Updated DialogComponent:

Wrapped the children of DialogComponent in a DialogContext.Provider and provided the setOpen function.
Updated DialogContent:

Used the useContext hook to access the setOpen function from DialogContext.
Updated the onClick handler of DialogClose to call setOpen(false) when provided.
By using context, we avoid directly passing the setOpen prop through component boundaries that don't expect it. This approach provides a cleaner and more flexible way to share the setOpen function with any child components that might need it.
TODO: WIDGET MUI should be defined.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants