Upgrade to wgpu 23

[tychedelia]

Fixes #15893

[djeedai]

Looks good to merge as long as we're OK to take a dependency on a moving target (I don't think we should). Also maybe the danger of upgrading to a new version close to release (but I understand it fixes some bug).

[JMS55]

No need to wrap bind groups in Some() anymore gfx-rs/wgpu#6452

[JMS55]

Actually that makes it worse... Can't automatically convert between bevy's and wgpu's bind group type...

note: required by a bound in `wgpu::RenderPass::<'encoder>::set_bind_group`
   --> C:\Users\Jasmine\.cargo\git\checkouts\wgpu-ebe3fb3e55696655\a9033f5\wgpu\src\api\render_pass.rs:80:26
    |
77  |     pub fn set_bind_group<'a>(
    |            -------------- required by a bound in this associated function
...
80  |         bind_group: impl Into<Option<&'a BindGroup>>,
    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `RenderPass::<'encoder>::set_bind_group`

error[E0277]: the trait bound `std::option::Option<&wgpu::BindGroup>: From<&bind_group::BindGroup>` is not satisfied
   --> crates\bevy_render\src\view\window\screenshot.rs:626:36
    |
626 |             pass.set_bind_group(0, &prepared_state.bind_group, &[]);
    |                  --------------    ^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `From<&bind_group::BindGroup>` is not implemented for `std::option::Option<&wgpu::BindGroup>`, which is required by `&bind_group::BindGroup: Into<std::option::Option<&wgpu::BindGroup>>`
    ```

[AlexAegis]

gfx-rs/wgpu#6465

Looks like wgpu 23 is about to release! 🎉

[Elabajaba]

This doesn't build on iOS currently according to Francois' testing.

[mockersf]

Just re-triggered a build, here is the failure: https://github.com/TheBevyFlock/bevy-example-runner/actions/runs/11533949819/job/32107445980

[tychedelia]

Just re-triggered a build, here is the failure: https://github.com/TheBevyFlock/bevy-example-runner/actions/runs/11533949819/job/32107445980

From last month:

gfx-rs/wgpu@fb0cb1e#diff-46fec780a1b7071adf9590bb9d55dfea0f97bd15419ccbe55ee89607fc244335R27

Edit: pushed a commit to attempt to fix this.

[BenjaminBrienen]

With cargo run --example relative_cursor_position I have to set the web-sys dependency to 0.3.72 and then it compiles.

[mockersf]

Edit: pushed a commit to attempt to fix this.

Building now works 🎉

[JMS55]

Might be worth letting wgpu people know that they should include it in the changelog for wgpu 23.

[mockersf]

released! https://github.com/gfx-rs/wgpu/releases/tag/v23.0.0

[JMS55]

Something we can finally now do is use const arrays with dynamic indexes, for e.g. shadow sampling patterns.

We should take advantage of this to cleanup a bunch of shader code.

[djeedai]

FYI this also brings CAS atomic operations to Metal. I didn't check if that was the last platform missing them (I expect wasm needs CORS, as with everything atomic due to security reasons, if it even supports CAS at the API level already).

[mockersf]

@tychedelia naga_oil 0.16 has been updated and released

[kristoff3r]

LGTM, I also tested a bunch of 2d/3d examples on Linux and WebGL and stuff seems to work.

[mockersf]

I would like to merge this one quickly and publish a new rc soon after, so get your reviews now! well in the next day or so

[JMS55]

Meshlets worked fine, code looks fine.