Add 0.15 release notes for function reflection #1768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrGVSV
force-pushed
the
mrgvsv/notes/function-reflection
branch
from
a57265c to
ad6897f
Compare
MiniaczQ
reviewed
Nov 3, 2024
MiniaczQ
reviewed
Nov 3, 2024
Contributor
|
I didn't see anything about overloading, will that be in separate notes or did that not land? |
Member
|
Overloading didn't land IIRC. |
Member
Author
Yeah unfortunately. But not too big a deal since that at least gives us more time to test it out. I did briefly mention it in the |
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com> Co-authored-by: MiniaczQ <xnetroidpl@gmail.com>
MrGVSV
commented
Nov 5, 2024
Comment on lines
+99
to
+105
| Using `FunctionInfo`, a `DynamicFunction` will print out its signature when debug-printed. | ||
|
|
||
| ```rust | ||
| dbg!(String::len.into_function()); | ||
| // Outputs: | ||
| // DynamicFunction(fn alloc::string::String::len(_: &alloc::string::String) -> usize) | ||
| ``` |
Member
Author
There was a problem hiding this comment.
Just added this because I think it's really cool we can still print out the full signature, but let me know if it's too much to include for the release post.
alice-i-cecile
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds release notes for the function reflection feature added this cycle.
This feature spans the following PRs (in order of date opened):
DynamicClosureandDynamicClosureMutbevy#14141DynamicFunctionergonomics bevy#14201DynamicClosure<'static>inFunctionRegistrybevy#14704functionsfeature docs bevy#15086FunctionRegistryinbevy_reflect::funcdocs bevy#15147FunctionRegistry::callbevy#15148Functiontrait bevy#15205Return::Unitvariant bevy#15484This feature has a lot to it. Please feel free to ask for additions/deletions/modifications!