Update protocol to support other bulb types#21
Open
mjg59 wants to merge 1 commit intobeville:masterfrom
Open
Conversation
The current implementation only supports RGB+W bulbs, but the protocol supports multiple other types. Add support for identifying the controller based on its ID byte, and add a real rgbw command for devices that handle it. In addition, there's some amount of support for devices that handle warm+cold white - this is entirely untested and unlikely to work well.
mjg59
referenced
this pull request
in mjg59/flux_led
Jan 20, 2017
…m_white Issue lightinglibs#15 - Fixed set warm white 75% to avoid turning off the light
reg-is
approved these changes
Mar 28, 2017
reg-is
left a comment
reg-is
left a comment
There was a problem hiding this comment.
The new -z command works great for me
|
We are trying to cleanup old PRs in this project Are you intrested in adding these to the models database? https://github.com/Danielhiversen/flux_led/blob/master/flux_led/models_db.py |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation only supports RGB+W bulbs, but the protocol
supports multiple other types. Add support for identifying the controller
based on its ID byte, and add a real rgbw command for devices that handle
it. In addition, there's some amount of support for devices that handle
warm+cold white - this is entirely untested and unlikely to work well.