Conversation
Code now tries using real interface broadcast addresses instead of relying on '<broadcast>', which has serious limitations associated with it. A fallback to previous behavior was implemented as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current code uses
<broadcast>, a.k.a.INADDR_BROADCAST, to scan for bulbs. I found that this doesn't work in all situations (including mine) due to the limitations of such broadcasts.In this PR I changed the code to use the
netifacespackage to find all interfaces, get their IPv4 broadcast address(es), and use them to broadcast the device discovery message. Ifnetifacesis unavailable or if for some reason it can't find any broadcast addresses, the code falls back to using<broadcast>.I preemptively apologize for any non-Pythonic code here; Python isn't something I use every day 😄