Merged
Conversation
Open
Owner
|
Awesome! |
Contributor
Author
|
Cool, thanks! Regarding the pipeline errors, this can be resolved by pinning the cheerio to version Or it may be worth updating the dependencies with a reproducible lockfile. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merge request introduces React v19 support for
use-between.The problem:
__CLIENT_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE(or on server:__SERVER_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE)HHis no longer a static value, but it is initiallynulland is reassigned based on certain conditions (see renderWithHooks)I solved this by:
__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIREDto remain compatible with React 18{ current }wrapper which forwards directly to theReactSharedInternals.Hpropertycurrentalways points to the current dispatcher used by React, as expected by use-between