Open
Conversation
Signed-off-by: Thomas Timmer <thomas.timmer@bettyblocks.com>
|
@thomas9911 it seems Ci wasn't triggered here, are the workflows disabled ? |
Author
yes because this is not the main repo. I can maybe enable those |
Aditya1404Sal
approved these changes
Jan 9, 2026
|
I ran unning tests/integration_http_blobby.rs (target/debug/deps/integration_http_blobby-6428d236c4957f4c)
running 2 tests
2026-01-09T20:14:11.830147Z ERROR wash_runtime::plugin::wasi_logging: Failed to write data to blobstore: container 'default' does not exist id="7395765b-3045-4d6a-8801-cfe2bae0c77d" context=""
test test_blobby_error_handling ... ok
2026-01-09T20:14:11.831586Z ERROR wash_runtime::plugin::wasi_logging: Failed to write data to blobstore: container 'default' does not exist id="2a6d0df4-71f3-4c86-af90-a1a5a17496fb" context=""
test test_blobby_integration ... FAILED
failures:
---- test_blobby_integration stdout ----
Starting blobby.wasm integration test
Created host with HTTP and blobstore plugins for blobby test
Host started, HTTP server listening on 127.0.0.1:35971
Started blobby workload: "172a537d-f1d8-4d5d-9211-f172d1b359ff"
Testing blobby component endpoint
GET Response Status: 404 Not Found
GET Response Body: Object not found
POST Response Status: 500 Internal Server Error
POST Response Body: Failed to write data to blobstore: container 'default' does not exist
thread 'test_blobby_integration' (910026) panicked at crates/wash-runtime/tests/integration_http_blobby.rs:189:5:
POST request expected success, got 500 Internal Server Error
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
failures:
test_blobby_integration
test result: FAILED. 1 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 6.14s |
Aditya1404Sal
suggested changes
Jan 9, 2026
Aditya1404Sal
left a comment
Aditya1404Sal
left a comment
There was a problem hiding this comment.
found some unnecessary clones, seemed to fix the failing blobby test
| @@ -11,6 +11,7 @@ use std::{ | |||
|
|
|||
| const WASI_BLOBSTORE_ID: &str = "wasi-blobstore"; | |||
| use tokio::sync::RwLock; | |||
There was a problem hiding this comment.
Suggested change
| use tokio::sync::RwLock; |
unused dep
Comment on lines
+121
to
+122
| let storage = plugin.storage.clone(); | ||
| let mut workload_storage = storage.entry(self.id.clone()).or_default(); |
There was a problem hiding this comment.
Suggested change
| let storage = plugin.storage.clone(); | |
| let mut workload_storage = storage.entry(self.id.clone()).or_default(); | |
| let mut workload_storage = plugin.storage.entry(self.id.clone()).or_default(); |
| let storage = plugin.storage.clone(); | ||
| let mut workload_storage = storage.entry(self.id.clone()).or_default(); | ||
|
|
||
| if workload_storage.contains_key(&name) { |
There was a problem hiding this comment.
Suggested change
| if workload_storage.contains_key(&name) { | |
| if workload_storage.value().contains_key(&name) { |
Comment on lines
+147
to
+148
| let storage = plugin.storage.clone(); | ||
| let does_contain_name = storage |
There was a problem hiding this comment.
Suggested change
| let storage = plugin.storage.clone(); | |
| let does_contain_name = storage | |
| let does_contain_name = plugin.storage |
Comment on lines
+169
to
+170
| let storage = plugin.storage.clone(); | ||
| let mut workload_storage = storage.entry(self.id.clone()).or_default(); |
There was a problem hiding this comment.
Suggested change
| let storage = plugin.storage.clone(); | |
| let mut workload_storage = storage.entry(self.id.clone()).or_default(); | |
| let mut workload_storage = plugin.storage.entry(self.id.clone()).or_default(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.