Define default fonts#1
Open
arhpreston wants to merge 1 commit intobettsmatt:masterfrom
arhpreston:defaults
Open
Define default fonts#1arhpreston wants to merge 1 commit intobettsmatt:masterfrom arhpreston:defaults
arhpreston wants to merge 1 commit intobettsmatt:masterfrom
arhpreston:defaults
Conversation
Owner
|
Sensible defaults are good. I'm not sure trying to find where fonts are installed per platform is the best approach. Could we include fonts in the package instead? |
Author
I guess you could package free fonts. Coding the paths for different distros works fine too. Your call. |
Owner
|
Tried to merge and it broke.
Alternatively we could check for system fonts when the module is loaded and then throw an exception after loading if none are found. We could also read these or a subset of them in to prevent looking up the font in every request. |
bettsmatt
added a commit
that referenced
this pull request
Dec 7, 2014
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few minor improvements:
Times New RomanandArial Bold) so users don't need to add any config to get up and runningget_fontto allow users to specify just the font name (rather than full path to font)