Conversation
* Add support for creating manual iClass credentials without needing to read from a source card or saved file.
* Pick Wiegand format, facility code, and card number, then emulate, write (to card), or save.
* Defaults to target legacy iClass (standard keys, 3DES) with a sensible CSN.
* Added a "Create Advanced" submenu for tweaking specific pacs data (pin/biometrics/encryption,etc) but, it currently remains commented out/hidden until it’s fully fleshed out and tested.
* Fixed typo in sio.asn1
bettse
left a comment
bettse
left a comment
There was a problem hiding this comment.
Sorry for the delay, turns out I didn't have the repo marked to "watch" and missed this completely. I haven't tested it yet, but there are some changes I'd like to have made first. A quick win would be to pull the emulate UI changes into it's own PR so I can merge that quickly. You'll see comments with some of the other stuff.
| widget_reset(widget); | ||
| widget_add_icon_element(widget, 0, 3, &I_RFIDDolphinSend_97x61); | ||
| widget_add_string_element(widget, 92, 30, AlignCenter, AlignTop, FontPrimary, "Emulating"); | ||
| widget_add_string_element(widget, 92, 25, AlignCenter, AlignTop, FontPrimary, "Emulating"); |
There was a problem hiding this comment.
Can you put the changes to this file into it's own PR?
| static PicopassCreateState create_state; | ||
| static bool create_state_initialized = false; | ||
|
|
||
| static uint32_t picopass_create_max_facility(WiegandFormat format) { |
There was a problem hiding this comment.
I know it gets wordy, but I'd prefer to still use the full terms "facility_code" and "card_number" (or I'll accept "fc" and "cn")
| @@ -0,0 +1,188 @@ | |||
| #include "../picopass_i.h" | |||
There was a problem hiding this comment.
Lets pull this out of the PR until it is ready
| picopass_create_apply_cred_type_defaults(picopass); | ||
| picopass_scene_create_update_menu(picopass); | ||
| consumed = true; | ||
| // Advanced scene temporarily disabled while being tested. |
There was a problem hiding this comment.
I'm not always the best at it myself, but I prefer not to check in commented out code
| CreateActionWrite, | ||
| CreateActionSave, | ||
| CreateActionCount, | ||
| } CreateAction; |
There was a problem hiding this comment.
Couldn't we just load the data up into the right struct and then push to the picopass_scene_saved_menu that has emulate/write/save?
2 participants
Add support for creating manual iClass credentials without needing to read from a source card or saved file.
Pick Wiegand format, facility code, and card number, then emulate, write (to card), or save.
Defaults to target legacy iClass (standard keys, 3DES) with a sensible CSN.
Added a "Create Advanced" submenu for tweaking specific pacs data (pin/biometrics/encryption,etc) but, it currently remains commented out/hidden until it’s fully fleshed out and tested.
Fixed typo in sio.asn1