Open
Conversation
This commit adds an initial version of the Authentication menu. This menu currently contains: - Document Number - Date of Birth - Date of Expiry - Authentication Method (Any, BAC only, PACE only) The idea is to also implement options to save and load authentication details to/from files.
…in passy. Log selected method in state machine
bettse
reviewed
Aug 20, 2025
Owner
bettse
left a comment
bettse
left a comment
There was a problem hiding this comment.
Thank you for the screenshot 👍 . I'd like to hold off on this until we've figured out the PACE EC/ECDH stuff first, but we can leave it open until then.
| SubmenuIndexDob, | ||
| SubmenuIndexDoe, | ||
| SubmenuIndexMethod, | ||
| // SubmenuIndexSave, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an initial version of the Authentication menu. This menu currently contains:
The idea is to also implement options to save and load authentication details to/from files.
PACE is not yet implemented, but shown in the authentication method menu. We could hide it for now, or remove the menu option altogether.
The selected auth method is stored in the
passystruct and logged in state machine.The new menu is a
VariableItemListwhich is included, initialized and available for other future scenes.