fix: DOM parsing for hidden-root accessibility pages#510
Closed
fix: DOM parsing for hidden-root accessibility pages#510
Conversation
Collaborator
Author
|
CF discussion dans #456 : Nous avons décidé de ne pas continuer dans cette direction |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #456
Summary
Page#domwas removing elements matchingvisibility:hidden.On some real sites, like https://www.agglo-larochelle.fr/ the root
<html>element is rendered withstyle="visibility:hidden", which caused the whole DOM to be stripped before audit checks ran.This PR makes
Page#doma raw parser again and keeps extraction cleanup separate.Changes
Page#domas the raw parsed documentscript,style,meta,link,noscript, andiframeResult
This restores for those sites with hidden attributes the detection
