Add PremiumService, normalize PremiumModel, refactor API/Cog, add tests and docs, bump discord.py#12
Draft
Add PremiumService, normalize PremiumModel, refactor API/Cog, add tests and docs, bump discord.py#12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
PremiumService(src/services/premium_service.py) that centralizesget_statusandactivate_with_paymentuse-cases and enforces idempotency and payment verification.src/database/models/premium.py) to normalize tier and payment method values and adjusted in-place activation/upsert behavior.src/api/routes/premium_api.py) to usePremiumServiceand simplified route logic to delegate verification/activation to the service; preserved a TODO for proper JWT auth.src/cogs/premium/premium.py) to usePremiumService, normalize displayed tiers, and fixed permission checks to useapp_commands.checks.has_permissions.discord.pyminimal version inrequirements.txtfrom>=2.3.0to>=2.5.2.docs/PRODUCTION_REFACTOR_AND_PREMIUM_PLAN.md,docs/REFACTOR_PLAN_DISCORDPY_PREMIUM.md) describing architecture, migration, and sprint roadmap.tests/test_premium_service.py) using lightweight dummy model/crypto service fakes.Testing
tests/test_premium_service.pycovering success path, idempotency, and unknown-tier handling foractivate_with_paymentand executed the suite withpytest.tests/test_premium_service.pypassed (3 tests, async pytest markers).Codex Task