Fanatec rotation range increase. #314
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks. It's mostly good, but the range slider is significantly longer than needed for wheels with a 900/1080 degree range. The marks up to 2520 aren't shown, making it look weirder. I think it would be greatly improved if the slider range changed dynamically to the max range needed. Could you update this PR with this change? |
Make some Fanatec wheel bases support 2520 degrees rotation.
As there are significant differences in wheel rotation, the approach now
has been to create a set of markers for {low, normal, high} range wheels
which allows all of them to be adapted independently.
All ranges start at 90, which is the lowest value, so the Scale will
always have a leftmost value. Tested with all current values in
device_manager.py.
tostr7191
force-pushed
the
fanatec_range
branch
from
2810de3 to
019d4bd
Compare
Author
|
I have updated it. The approach I took seems reasonable to me. I was originally considering doing some math to figure the markers out, but in the end I don't think it's really worth it since there seem to be clear categories of wheel (ie low, normal, high). LMK if that works for you! Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #243
Make some Fanatec wheel bases support 2520 degrees rotation.
This also changes the steps in the
GtkScalea bit to make space for the higher numbers.I have also changed the minimum value for the Rotation range to 90, since I got errors when going below that. 90 already seems like an unlikely low value, but if there are reasons to not change that I can undo it ofc.
I only have a CSL DD, the values are also changed for
FT_CSL_ELITEandFT_CSL_ELITE_PS4. The rest I am unsure, especially theFT_PDD1andFT_PDD2. If anyone can test this on the elite/elite ps4 that would be much appreciated.To test this you can clone and check out
fanatec_rangeand then:This just runs it from the repo without installing.