This repository was archived by the owner on Mar 20, 2020. It is now read-only.
dev: update dependencies #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
commit aef39c0 Proposal to clean up the app structure and unify the configuration |
Owner
|
I'm finally back from traveling so I should have a chance to look at this in detail soon - thanks for the PR! |
benwr
suggested changes
Aug 6, 2019
Owner
benwr
left a comment
benwr
left a comment
There was a problem hiding this comment.
Mostly looks good; thanks for the PR and especially for updating the readme!
ankdown/ankdown.py
Outdated
| """Need to extract the math in brackets so that it doesn't get markdowned. | ||
| If math is separated with dollar sign it is converted to brackets.""" | ||
| if CONFIG['dollar']: | ||
| if CONFIG['math_mode'] is 'dollars': |
Contributor
Author
There was a problem hiding this comment.
oh... coffeescript sneaks in ;-) I've pushed a fix
ankdown/ankdown.py
Outdated
|
|
||
|
|
||
| return misaka.html(field, extensions=("fenced-code", "math")) | ||
| if CONFIG['misaka_renderer'] is 'HighlighterRenderer': |
ankdown/ankdown.py
Outdated
| # | ||
| # add highlight css rules | ||
| # | ||
| if CONFIG['misaka_renderer'] is 'HighlighterRenderer': |
Contributor
Author
|
Did you notice my change commit? ;-) |
Owner
|
Sorry! I've been super busy again the last month or so; I'll try to merge this tonight (although my power and internet might be shut off so no promises) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #19