Corrections made for using PMUC as a shared library in another project#36
Open
msv68 wants to merge 7 commits intobenvautrin:masterfrom
Open
Corrections made for using PMUC as a shared library in another project#36msv68 wants to merge 7 commits intobenvautrin:masterfrom
msv68 wants to merge 7 commits intobenvautrin:masterfrom
Conversation
msv68
force-pushed
the
develop
branch
3 times, most recently
from
32159e2 to
004537b
Compare
Added cmake-lib/CMakeLists.txt to build shared library on Windows and Linux. Make possibility to exclude the class rvmmeshhelper from the library to get rid of dependence on OpenGl. For that the cmake Boolean option USE_MESH_HELPER has been added. Removed some warnings.
The patch fixes exception when a key is empty, like "Module:=".
By the way fix memory leak through m_attributeStream.
When objects in ATT file follow in another order in comparison with RVM file some objects could miss the attributes. The patch fixes this bug.
nbogdanlogic
force-pushed
the
develop
branch
6 times, most recently
from
bdba4ab to
3c5925e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are several commits in this branch to merge into master.