Skip to content

fix(persons): NULL value for sexId (#273) #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bensteUEM merged 1 commit into from
Jul 20, 2025
Merged

fix(persons): NULL value for sexId (#273) #277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions churchtools_api/persons.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,8 @@ def get_persons_masterdata(
"""Function to get the Masterdata of the persons module.

This information is required to map some IDs to specific items.
Special case treatment for resultClass sexes
first item is copied for "None" references as fallback

Arguments:
resultClass: the name of the masterdata to retrieve. Defaults to All
Expand All @@ -111,8 +113,11 @@ def get_persons_masterdata(

if resultClass:
response_data = response_data[resultClass]
if resultClass == "sexes":
response_data.insert(0, {**response_data[0], "id": None})
if returnAsDict:
response_data = {item["id"]: item["name"] for item in response_data}
response_data[None] = response_data[0]

logger.debug("Person Masterdata load successful len=%s", len(response_data))

Expand Down
19 changes: 17 additions & 2 deletions tests/test_churchtools_api_persons.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,10 +111,25 @@ def test_get_persons_sex_id(self) -> None:
EXPECTED_RESULT = "sex.unknown"
SAMPLE_USER_ID = 513

person = self.api.get_persons(ids=[SAMPLE_USER_ID])
person = self.api.get_persons(ids=[SAMPLE_USER_ID])[0]
gender_map = self.api.get_persons_masterdata(
resultClass="sexes", returnAsDict=True
)
result = gender_map[person[0]["sexId"]]
result = gender_map[person["sexId"]]

assert result == EXPECTED_RESULT

def test_get_persons_sex_id_none(self) -> None:
"""Tests that persons sexId can be converted if NULL.

IMPORTANT - This test method and the parameters used depend on target system!
the hard coded sample exists on ELKW1610.KRZ.TOOLS
"""
EXPECTED_RESULT = "sex.unknown"

gender_map = self.api.get_persons_masterdata(
resultClass="sexes", returnAsDict=True
)
result = gender_map[None]

assert result == EXPECTED_RESULT
Loading