Add unit tests for validation logic in QueryGenerator::generateQuery() #92
+74
−25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #91 (follow up pr after #89)
Summary
Adds validation for natural language query input and unit tests to cover the validation logic used by
QueryGenerator::generateQuery().Changes
validate_natural_language_query()inutilsto enforce:max_query_length)QueryGenerator::generateQuery()now calls this validator before proceeding and returns aQueryResultwithsuccess = falseand a clear error message when validation fails.tests/unit/test_utils.cppfor:Testing
make test-setup && ./build_tests/tests/pg_ai_query_tests --gtest_filter="UtilsTest.ValidateNaturalLanguageQuery_*"