feat: add configurable system prompts feature #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add [prompts] section to configuration file - Support custom system_prompt and explain_system_prompt - Accept both inline strings and file paths for prompts - Fallback to built-in defaults when not configured - Update query_generator to use new prompt getter functions - Add comprehensive unit tests (14 test cases) - Update configuration documentation with examples Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Remove hardcoded local paths from test cases - Use getFixturesPath() for environment-independent path resolution - Replace directory switching with absolute path construction - Add fstream header for file operations Fixes test failures in: - GetSystemPromptLoadsFromFile - GetExplainSystemPromptLoadsFromFile All 111 tests now pass successfully. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE #93
Since IvorySQL is a PostgreSQL-based database with Oracle compatibility features, modifications to system prompts are required. Therefore, this feature is submitted to support prompt customization, with the
docsandtestsassisted by @claude.Automatic fallback to built-in defaults when not configured
Option 1: Inline String (Short Prompts)
~/.pg_ai.config
[prompts]
system_prompt = "You are a PostgreSQL expert for financial data. Always include index recommendations."
explain_system_prompt = "Focus on materialized view usage and query optimization."
Option 2: File Path (Long Prompts - Recommended)
~/.pg_ai.config
[prompts]
system_prompt = /home/user/.pg_ai.prompts
explain_system_prompt = /home/user/.pg_ai.explain.prompts