refactor: replace bare catch(...) with specific exception handling (#49) #85
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #49 by replacing bare
catch(...)blocks with specific exception handling to prevent swallowing errors and improve debuggability.Key changes
src/core/query_parser.cpp:nlohmann::json::parse_errorspecifically for JSON parsing operations.std::exceptionas a fallback for other errors.src/core/query_generator.cpp:catch(...)withcatch(const std::exception&)inbuildPrompt.Builds fine, all tests run okay .