Skip to content

Conversation

@Justxd22
Copy link
Contributor

@Justxd22 Justxd22 commented Feb 9, 2026

This PR addresses issue #49 by replacing bare catch(...) blocks with specific exception handling to prevent swallowing errors and improve debuggability.

Key changes

  • In src/core/query_parser.cpp:
    • Caught nlohmann::json::parse_error specifically for JSON parsing operations.
    • Caught std::exception as a fallback for other errors.
    • Added debug/warning logs with the exception message.
  • In src/core/query_generator.cpp:
    • Replaced catch(...) with catch(const std::exception&) in buildPrompt.
    • Added warning logs with the exception message.

Builds fine, all tests run okay .

@Justxd22 Justxd22 requested a review from benodiwal as a code owner February 9, 2026 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant