Skip to content

Build child process tree in windows using wmic #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benmerckx merged 2 commits into from
Feb 3, 2025
Merged

Build child process tree in windows using wmic #8

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8414cb
Use SIGTERM instead of SIGKILL when terminating old processes
jefvel Jan 28, 2025
d1bf4da
Get child process pids for process tree in windows using the wmic com…
jefvel Feb 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 38 additions & 21 deletions src/watch/Watch.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,9 +177,28 @@ function runCommand(command: String) {
final pidsToProcess = [pid => true];
buildProcessTree(pid, tree, pidsToProcess, parentPid -> {
// Get processes with parent pid
final psargs = '-o pid --no-headers --ppid $parentPid';
final ps = new sys.io.Process('ps $psargs');
ps;
var pids:Array<Int> = null;
var result:sys.io.Process = null;
if (Sys.systemName() == "Windows") {
final psargs = 'process where (ParentProcessId=${parentPid}) get ProcessId';
final args = 'cmd.exe /c wmic $psargs';
result = new sys.io.Process(args);
if (result.exitCode() == 0) {
var pidResult = result.stdout.readAll().toString();
var pidStrings = pidResult.split("\n").slice(1); // Remove first line ("ProcessId")
pids = pidStrings.map(pidString -> Std.parseInt(pidString)).filter(p -> p != null);
}
} else {
final psargs = '-o pid --no-headers --ppid $parentPid';
result = new sys.io.Process('ps $psargs');
if (result.exitCode() == 0) {
pids = [Std.parseInt(result.stdout.readAll().toString())];
}
}

result?.close();

return pids;
}, () -> {
killAll(tree, _ -> cb());
});
Expand All @@ -192,25 +211,23 @@ function runCommand(command: String) {
}
}

function buildProcessTree(parentPid: Int, tree: Map<Int, Array<Int>>, pidsToProcess: Map<Int, Bool>, getChildPpid: (pid: Int) -> sys.io.Process, cb:() -> Void) {
final result = getChildPpid(parentPid);
if (result.exitCode() == 0) {
pidsToProcess.remove(parentPid);
final pid = Std.parseInt(result.stdout.readAll().toString());
final children = tree.get(parentPid) ?? [];
if (!children.has(pid)) {
children.push(pid);
}
tree.set(parentPid, children);
tree.set(pid, []);
pidsToProcess.set(pid, true);
buildProcessTree(pid, tree, pidsToProcess, getChildPpid, cb);
function buildProcessTree(parentPid: Int, tree: Map<Int, Array<Int>>, pidsToProcess: Map<Int, Bool>, getChildPpid: (pid: Int) -> Array<Int>, cb:() -> Void) {
final childPids = getChildPpid(parentPid);
if (childPids != null && childPids.length > 0) {
pidsToProcess.remove(parentPid);
for (pid in childPids) {
final children = tree.get(parentPid) ?? [];
if (!children.has(pid)) {
children.push(pid);
}
tree.set(parentPid, children);
pidsToProcess.set(pid, true);
buildProcessTree(pid, tree, pidsToProcess, getChildPpid, cb);
}
} else {
pidsToProcess.remove(parentPid);
cb();
}

result.close();
}

function killAll(tree: Map<Int, Array<Int>>, callback: (error: Option<String>) -> Void) {
Expand All @@ -220,15 +237,15 @@ function killAll(tree: Map<Int, Array<Int>>, callback: (error: Option<String>) -
tree.get(pid).iter(pidpid -> {
final isKilled = killed.get(pidpid) ?? false;
if (!isKilled) {
switch Process.killPid(pidpid, SIGKILL) {
switch Process.killPid(pidpid, SIGTERM) {
case Ok(_):
killed.set(pidpid, true);
case Error(e):
}
}
});
if (!(killed.get(pid) ?? false)) {
switch Process.killPid(pid, SIGKILL) {
switch Process.killPid(pid, SIGTERM) {
case Ok(_):
killed.set(pid, true);
case Error(e):
Expand Down Expand Up @@ -454,4 +471,4 @@ function register() {
});
});
loop.loop();
}
}