Register: fix exception when resolve[Register.init] has already been cleared#79
Merged
benmerckx merged 1 commit intobenmerckx:masterfrom Apr 21, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases, it appears that calling
resolve[Register.init]()fails becauseresolve[Register.init]is undefined. There is a check forif (resolve && resolve[Register.init]), but I guess that__init__gets must be getting set to undefined at some point after that check.I can reproduce the issue with this sample.
https://github.com/joshtynjala/openfl-genes-sample
I have the latest OpenFL and Lime and Haxe 4.3.6 installed.