Fix argument droplevels=FALSE ignored for table1.formula#145
Open
mheinric wants to merge 1 commit intobenjaminrich:masterfrom
Open
Fix argument droplevels=FALSE ignored for table1.formula#145mheinric wants to merge 1 commit intobenjaminrich:masterfrom
mheinric wants to merge 1 commit intobenjaminrich:masterfrom
Conversation
When calling function table1(), the argument droplevels=FALSE had no effect. The issue was introduced in c0a31d2 where lapply(m2, as.factor) was replaced by lapply(m2, factorp). The first one preserves the levels of the original columns, while the second does not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The argument droplevels of the table1.formula function was ignored. For example in the code below:
we would expect the column "Unused" to appear in the resulting table, but this is not the case.
The issue was introduced in c0a31d2 where the line 1516 in table1.R was changed from
m2 <- lapply(m2, as.factor)tom2 <- lapply(m2, factorp). The first one preserves the levels of the source columns, while the second does not.PS: thanks for such a nice package =).