Draft
Conversation
* Fix render of the Highlight thread * Remove placeholder for Highlight hyperlink - it isn't possible to have an instance independent link. * Take boxscore & linescore out of the Highlight thread. It looked too much like the game thread.
Fix merge conflict.
benja810
approved these changes
Jul 9, 2023
| self.commonData[pk]["schedule"]["status"]["statusCode"], | ||
| edit=False, | ||
| ) | ||
| if self.settings.get("Highlight Thread", {}).get( |
Owner
There was a problem hiding this comment.
This all looks good but what do you think about splitting the highlight thread code into it's own function or file + function? Use it as sort of a template for future refactoring?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3