Skip to content

refactor checkout #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benhalverson merged 2 commits into from
Dec 10, 2025
Merged

refactor checkout #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b717b8
refactor checkout
bayareafilms Dec 10, 2025
f606fa1
Update src/pages/Checkout.tsx
benhalverson Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/pages/Checkout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,11 +230,9 @@ export default function Checkout() {
navigate(data.checkout_url);
return;
}
// If backend returned a Stripe client secret, navigate to a route that can handle it
const clientSecret = data.clientSecret ?? data.client_secret;
if (clientSecret) {
// Navigate to the payment page which loads Stripe Elements and completes confirmation
navigate(`/payment?client_secret=${encodeURIComponent(clientSecret)}`);
navigate(`/payment`, { state: { clientSecret } });
return;
}
// Fallback: optionally navigate if order id provided
Expand Down
4 changes: 3 additions & 1 deletion src/pages/Payment.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,9 @@ function PaymentForm() {
export default function PaymentPage() {
const loc = useLocation();
const q = useMemo(() => new URLSearchParams(loc.search), [loc.search]);
const clientSecret = q.get("client_secret");
// Prefer router state (in-memory) to avoid exposing secrets in the URL.
const state = (loc.state as { clientSecret?: string } | null) ?? null;
const clientSecret = state?.clientSecret ?? q.get("client_secret");

if (!publishableKey) {
return (
Expand Down