Replacing uglify-webpack-plugin because of security vulnerability #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first pull request, so please be patient :-) Specifically I don't know how to exclude files from pull requests as my fork is deviating in some things from upstream.
This pull request replaces uglify-webpack-plugin with terser-webpack-plugin.
Reason: The former plugin is discontinued, but depends on a vulnerable version of serialize-javascript. It does not receive any further updates, so a replacement is necessary.
The only necessary changes are in webpack.prod.config.js and accordingly to package.json
The code change in webpack.prod.config.js should be sufficient, but cleanup in package.json and package-log.json is necessary, but a simple exercise for Node.js developers.