This repository was archived by the owner on May 24, 2022. It is now read-only.
Template implementation and bug fixes #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the CSS style to extend the top border of the footer in order to use the scroll feature properly
Bunch of typos littered through out
Image used by the cancel image button
…nformation > Created a basic template for the Horizontal Bar graph > Templates modified to more accurately represent the image classification and create the right description for the editor > Basic code cleanup
> Templates migrated from how.html now work if the user selects an appropriate classification > When the user changes classifications, the modal starts at the step1 to display correct guidelines and remove previous description > "Try Describing This Image" button now properly disables after the user tries to describe a new image after the first time > Button added to remove image if the user selects the wrong image and correctly disables the "Try Describing This Image" button
An explanation and general overview of what we have done is located here. This includes the distribution of work and where we changed things.
sholzer20
changed the title
Author
|
Requesting a review of our commits. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Report and Fixes Amanda Johnston, Andrew McNeill, & Sam Holzer
Hello,
We are a team of Computer Science students that decided to try and assist in your Poet Training Tool, for the Poet Image Description Tool. We noticed at first that some of the 16 issues listed in the bug tracker were already fixed and yet were still on the list. After commenting on the GitHub, letting you know about the finished issues and asking if they were actually completed, all of the issues were closed at once. Coming to the conclusion that we needed to dig deeper, our team dived into the code. While several of the bugs had been resolved, there were still others we could explore and attempt to fix or improve. One member of our team, Amanda, worked on finding any and all typos within the Poet Training Tool. The “When to Describe” was very well put-together and contained no noticeable bugs. However, the “How to Describe” page was filled with grammatical errors and faulty images that were almost impossible to interpret. With these bugs in mind, Andrew and Amanda went about fixing the grammatical errors and noted any images that needed to be reuploaded or changed in general. Andrew also worked on fixing the scrolling menu bugs in the “How to Describe” and “Practice” pages. The menu would just hop to the end once the page was at the bottom. Even if you clicked on number 6, the number 8 would be highlighted. Andrew eventually managed to figure out a solution for this problem. Andrew also worked on fixing the resizing issues with the navigation bar. The idea is that if the screen becomes small enough, the header links will move into a navigation bar. This is implemented, but it is rather buggy, as the text appears overlayed on the wrong side of the screen when the button is pressed. He is currently working on how to fix this issue. Sam worked on the “Practice” page to implement a template for the describer to fill in the information for certain image types. This includes Venn diagrams, horizontal bar graphs, vertical bar graphs, pie charts, scatter plots, and line plots. He also allowed the describer to remove an image once you have added it to the “Practice” page. In all, our group has added many quality additions to the project and helped fix many issues within the Poet Training Module code. We hope that you see this project and consider pulling our commits into the master branch. We believe in the cause the Poet Image Description Tool stands for and wish to be a part of the organization. Please refer to the commit descriptions for specific details on work completed.
Summary:
Amanda: ● Find any bugs ● Find typos ● Find photos with issues ● Final Documentation
Andrew: ● Find typos ● Fix typos ● Fix menu issues ● Fix navigation bar
Sam: ● Commit changes to local repository and fork to your repository ● Create templates in the “Practice” pages ● Fix issues with buttons in the pop-up window ● Added a remove image button to the “Practice” page