This repository was archived by the owner on May 24, 2022. It is now read-only.
Add option to navigate by sentence. #239
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a setting to toggle between navigating by sentence and navigating by paragraph. The default is paragraph, which matches the previous intended behavior. Opening any setting crashed the app because of a ClassCastException from FrameLayout to LinearLayout. I changed the cast to ViewGroup, as the code didn't actually depend on anything more specific. Navigation by paragraph was unreliable when the app was reading because the TTS callback would happen on other threads while navigation happened. I've reposted the TTS callbacks to the main thread to prevent threads interfering with each other. Issue benetech#33 is an example of this problem. Callbacks from TTS also didn't distinguish between utterances that had been read and utterances whose reading had been canceled. I've added logic to track which utterances are currently active, and ignore callback for those that have been cancelled. I now find that both types of navigation now work reliably.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a setting to toggle between navigating by
sentence and navigating by paragraph. The default
is paragraph, which matches the previous intended
behavior.
Opening any setting crashed the app because of a
ClassCastException from FrameLayout to LinearLayout.
I changed the cast to ViewGroup, as the code didn't
actually depend on anything more specific.
Navigation by paragraph was unreliable when
the app was reading because the TTS callback would
happen on other threads while navigation happened.
I've reposted the TTS callbacks to the main thread
to prevent threads interfering with each other.
Issue #33 is an example of this problem.
Callbacks from TTS also didn't distinguish between
utterances that had been read and utterances whose
reading had been canceled. I've added logic to track
which utterances are currently active, and ignore
callback for those that have been cancelled.
I now find that both types of navigation now work
reliably.