support selector in 'on' function

[liady]

Support selector passing in "on" function (optional).
If passed, the handler first checks the event target to match the selector.

[sqal]

This is not working as it should, Check out demo: http://jsfiddle.net/q8grdnxa/

It should detect if user clicks on any element within delegated element.

[liady]

Thanks. Changed to a limited "closest" check:
http://jsfiddle.net/q8grdnxa/1/

[sqal]

👍 Thank you @liady

[sqal]

I just noticed that $(document).ready event doesn't fire after your changes @liady Can you check what is wrong?

Worse, can't attach single event to element without additional selector parameter

[sqal]

There needs to be check if selector is a string, because if user do not pass selector it becomes a handler function which evaluates to true ofc :)

[liady]

You're right, I already handled that case but didn't clear the selector variable. Fixed now:
http://jsfiddle.net/q8grdnxa/2/