Skip to content

DRAFT: Chromatic noise#8

Open
jeremy-baier wants to merge 4 commits intobencebecsy:mainfrom
jeremy-baier:jgb-add-chrom-delay
Open

DRAFT: Chromatic noise#8
jeremy-baier wants to merge 4 commits intobencebecsy:mainfrom
jeremy-baier:jgb-add-chrom-delay

Conversation

@jeremy-baier
Copy link

This PR adds support for injecting chromatic (in radio frequency) noise — including dm noise — into a pulsar’s residuals.

@jeremy-baier jeremy-baier changed the title Chromatic noise DRAFT: Chromatic noise Jun 8, 2024
@bencebecsy
Copy link
Owner

I think this looks great @jeremy-baier !
Have you tested this for consistency with either 1) comparing the injected residuals between this and libstempo.toasim.add_dm or 2) via injecting stuff with this and recovering with usual enterprise analysis?
I think it would be good to see either of those before merging this

@jeremy-baier
Copy link
Author

I have not had a chance to test it yet @bencebecsy .
I will try the enterprise recovery and get back to you !

@bencebecsy
Copy link
Owner

@jeremy-baier I see there's been some changes to this since you opened the PR. Did you managed to test a recovery from this or a comparison with libstempo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants