MST-18: Create reusable Login component in component library #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MST-18: Create reusable Login component in component library
Summary
This PR creates a reusable
Logincomponent in the component library and replaces the existing login forms inbrowse-app,vg-browse, andmy-account-app. The component is fully parameterized to support different themes, logos, and social sign-in options across all three applications.Key Changes:
Logincomponent following theSearchBarpattern withLogin.js,Login.css, andindex.jsmy-account-appthat caused social login buttons to overlapReview & Testing Checklist for Human
Recommended Test Plan:
Diagram
%%{ init : { "theme" : "default" }}%% graph TB CL["component-library/src/components/Login/"]:::major-edit CLIndex["component-library/src/index.js"]:::minor-edit BA["browse-app/src/Login.js"]:::major-edit BAApp["browse-app/src/App.css"]:::minor-edit VG["vg-browse/src/Login.js"]:::major-edit VGApp["vg-browse/src/App.css"]:::minor-edit MA["my-account-app/src/components/Login.tsx"]:::major-edit MASite["my-account-app/src/styles/site.css"]:::minor-edit CL --> BA CL --> VG CL --> MA CLIndex -.-> CL BAApp -.-> BA VGApp -.-> VG MASite -.-> MA subgraph Legend L1["Major Edit"]:::major-edit L2["Minor Edit"]:::minor-edit L3["Context/No Edit"]:::context end classDef major-edit fill:#90EE90 classDef minor-edit fill:#87CEEB classDef context fill:#FFFFFFNotes
npm packfor Create React App environments.my-account-app/src/styles/site.cssthat were causing layout overlap issues.Session Details: