-
Notifications
You must be signed in to change notification settings - Fork 1
ssh support and a second round of abstract file operations #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
richfitz
wants to merge
30
commits into
ben-gready:master
Choose a base branch
from
richfitz:ssh
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
b9c6954
Docker image for testing ssh
richfitz 4f8570f
Add basic test infrastructure
richfitz ccaa05d
Basic support for creating/removing sshd server
richfitz cc4c7a4
Add helper for making connection
richfitz bf46bb8
Store keys within sshd path
richfitz bf9ddfb
Basic ssh file ops implemented
richfitz d5b9757
Vectorised exists/delete and report exists on delete
richfitz 8bc3e5b
Human-readable ops type
richfitz 8af8cd2
Tidy up the ssh ops
richfitz 39b3ebf
Make key finding more robust in test
richfitz 2932ad6
Add generalised remote storr driver
richfitz 19a3ddc
Full rds configuration support
richfitz 3c41d30
Big simplification based on storr update
richfitz b3da3f2
Tweaks for changes to storr
richfitz d73c961
Expand testing
richfitz d824c98
Tests for assertions
richfitz 72e93b0
Minimal roxygen
richfitz 3f7e6f0
Untested port of the s3 driver
richfitz fab9f3f
Disable root login
richfitz acc3af0
Don't start ssh server if ssh package not found
richfitz d2d31cd
Docs for running tests
richfitz 6b25452
Update to use dest_dir not dest for download_file
richfitz 4761f46
Add travis (just on my fork for now)
richfitz fa2923f
Update storr reference
richfitz 60f7bbd
Add default_argument documentation
richfitz dc0a7ba
Add a licence
richfitz f1b8543
Fix typo
richfitz 50f7ba0
Enable tests on travis
richfitz 8058f65
More QA tweaks
richfitz 1aec88c
Everything on cran now
richfitz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,3 @@ | ||
| ^.*\.Rproj$ | ||
| ^\.Rproj\.user$ | ||
| ^\.travis\.yml$ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| language: r | ||
| cache: packages | ||
|
|
||
| # Departure from usual setup because we need docker for testing | ||
| sudo: true | ||
| service: docker | ||
|
|
||
| # Make tests more reliable by getting this up early | ||
| before_script: | ||
| - docker pull sickp/alpine-sshd:latest | ||
| - docker build tests/testthat/sshd | ||
|
|
||
| env: | ||
| - STORR_REMOTE_USE_SSHD=true | ||
|
|
||
| # Not 'addon' based because we're on sudo infrastructure | ||
| apt_packages: | ||
| - libssh-dev | ||
|
|
||
| # Test coverage | ||
| r_packages: | ||
| - covr | ||
| after_success: | ||
| - Rscript -e 'covr::codecov()' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| YEAR: 2018 | ||
| COPYRIGHT HOLDER: Ben Gready | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,6 @@ | ||
| # Generated by roxygen2: do not edit by hand | ||
|
|
||
| export(storr_rds_s3) | ||
| export(driver_s3) | ||
| export(driver_ssh) | ||
| export(storr_s3) | ||
| export(storr_ssh) |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this and the license. It's something I've basically not thought of much before. If it's acceptable to add more than one person, happy for you to be on here as well.