Skip to content

Basic CI Flows #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mguludag merged 8 commits into from
Dec 14, 2025
Merged

Basic CI Flows #115

mguludag merged 8 commits into from
Dec 14, 2025

Conversation

@mguludag
Copy link
Member

@mguludag mguludag commented Dec 13, 2025

#22 Add basic CI flows

  • pre-commit checks added
  • added trunk check (linter collection with various linters enabled)
  • enabled linters:
    • actionlint@1.7.9
    • bandit@1.9.2
    • black@25.12.0
    • checkov@3.2.495
    • git-diff-check
    • isort@7.0.0
    • markdownlint@0.47.0
    • osv-scanner@2.3.1
    • oxipng@10.0.0
    • prettier@3.7.4
    • ruff@0.14.9
    • shellcheck@0.11.0
    • shfmt@3.6.0
    • svgo@4.0.0
    • trufflehog@3.92.3
    • yamllint@1.37.1

@mguludag mguludag self-assigned this Dec 13, 2025
@mguludag mguludag linked an issue Dec 13, 2025 that may be closed by this pull request
Add basic CI flows #22
Closed
3 tasks
@netlify
Copy link

netlify bot commented Dec 13, 2025 •
edited
Loading

✅ Deploy Preview for bemanproject ready!

Name Link
🔨 Latest commit 214fb15
🔍 Latest deploy log https://app.netlify.com/projects/bemanproject/deploys/693f0e3cf311dc0008ab10d5
😎 Deploy Preview https://deploy-preview-115--bemanproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

JeffGarland
JeffGarland reviewed Dec 14, 2025
View reviewed changes
docs/beman_library_maturity_model.md
Copy link
Member

@JeffGarland JeffGarland Dec 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk if this really applys to this PR, but I believe this file is now out of date as the maturity model now includes the process to go to production ready

JeffGarland
JeffGarland reviewed Dec 14, 2025
View reviewed changes
docs/beman_standard.md Outdated
```markdown
**Implements**: [`std::optional<T&>` (P2988R5)](https://wg21.link/P2988R5) and
[Give *std::optional* Range Support (P3168R1)](https://wg21.link/P3168R1).
[Give _std::optional_ Range Support (P3168R1)](https://wg21.link/P3168R1).
Copy link
Member

@JeffGarland JeffGarland Dec 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The std::optional is for italic, but that isn't really what we want I think? We just want code font like this: std::optional?

Copy link
Member Author

@mguludag mguludag Dec 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the formatter from linter changed it but I changed it to use double * and seems fine for the formatter

JeffGarland
JeffGarland approved these changes Dec 14, 2025
View reviewed changes
Copy link
Member

@JeffGarland JeffGarland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving - this mostly seems like whitespace changes. I'm kinda clueless on some of the yaml, but I trust it's fine.

@mguludag mguludag merged commit 0fd4f42 into main Dec 14, 2025
5 of 8 checks passed
@neatudarius neatudarius mentioned this pull request Dec 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JeffGarland JeffGarland JeffGarland approved these changes

@neatudarius neatudarius Awaiting requested review from neatudarius neatudarius is a code owner

@RaduNichita RaduNichita Awaiting requested review from RaduNichita RaduNichita is a code owner

@inbal2l inbal2l Awaiting requested review from inbal2l inbal2l is a code owner

@ednolan ednolan Awaiting requested review from ednolan ednolan is a code owner

@camio camio Awaiting requested review from camio camio is a code owner

Assignees

@mguludag mguludag

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add basic CI flows

3 participants

@mguludag @JeffGarland