Add options to use build-details.json as input#30
Draft
freakboy3742 wants to merge 1 commit intomainfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At present,
xvenvandxbuildaccept--sysconfigas an argument; the sysconfig file would then be used to extract configuration data that would the be used to shape the cross platform configuration.Following some discussions at the Python core team summit in September, this PR adds a
--build-detailsoption, allowing the use of abuild_details.jsonfile. The build-details file is a better source of normalised configuration information about a build.Created as a draft; partially because there's more manual testing required - but also because I was hoping to use this as an opportunity to add an actual test suite.
PR Checklist: