Skip to content

Add in-app Goal Settings page #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
theospears wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add in-app Goal Settings page #726

theospears wants to merge 1 commit into from
+212 −7

Conversation

@theospears
Copy link
Collaborator

@theospears theospears commented Jan 19, 2026

Summary

  • Adds a new Goal Settings page accessible from the goal view menu
  • Provides quick access to notification settings and data source configuration without leaving the app
  • Shows notification status (disabled/using defaults/X days or hours before)
  • Shows data source (Apple Health metric, other autodata, or option to connect)
  • Menu restructured with Goal Settings at top, web links below with URL header
  • Menu icon changed from share icon to ellipsis.circle
  • Fixes SnapKit constraint crash in ConfigureHKMetricViewController when no health data is available

Test plan

  • Navigate to any goal and tap the menu icon (ellipsis.circle)
  • Verify "Goal Settings" appears at the top of the menu, above the URL section
  • Tap "Goal Settings" and verify navigation to the new settings page
  • Verify "Notifications" row shows correct status and navigates to notification settings
  • For an Apple Health goal: verify data source shows the metric name and is tappable
  • For a manual goal: verify data source shows "Connect to Apple Health" and is tappable
  • For other autodata (Fitbit, API, etc.): verify data source shows the name and is NOT tappable
  • Verify all existing web links in the menu still work

🤖 Generated with Claude Code

@theospears theospears requested a review from a team as a code owner January 19, 2026 05:43
@theospears @claude
Add in-app Goal Settings page
a48bb34 
Add a new Goal Settings page accessible from the goal view menu that
provides quick access to notification and data source settings without
leaving the app.

Changes:
- New GoalSettingsViewController with notifications and data source rows
- Notifications row shows status (disabled/using defaults/X days before)
- Data source row shows current source or option to connect Apple Health
- Menu restructured with Goal Settings above web links section
- Menu icon changed to ellipsis.circle for better discoverability
- Fix SnapKit constraint crash in ConfigureHKMetricViewController

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@theospears