Open
Conversation
Author
|
Looks good to me! |
| await this.plugin.send({ | ||
| pluginId: this.plugin.pluginId, | ||
| actions: { | ||
| actions: [{ |
Contributor
There was a problem hiding this comment.
change all of these usages to use a sendActions which takes []Action
|
|
||
| if (actions.length > 0) { | ||
| await this.plugin.send({ | ||
| pluginId: this.plugin.pluginId, |
Contributor
There was a problem hiding this comment.
use a sendActions method
| timeValue = value; | ||
| } | ||
|
|
||
| await this.plugin.sendAction('worldSetTime', { |
Contributor
There was a problem hiding this comment.
use a sendActions method
| await context.ack(); | ||
| } | ||
|
|
||
| // --- Commands --- |
Contributor
There was a problem hiding this comment.
move everything below this into commands.ts
|
|
||
| await playerData.save(); | ||
|
|
||
| await context.ack(); |
Contributor
There was a problem hiding this comment.
we should avoid acks at the end with an internal ackIfUnhandled
| players/ | ||
| resources/ | ||
|
|
||
| cmd/plugins/plugins.yaml |
Contributor
There was a problem hiding this comment.
we should keep some example plugins.yaml if this is going to be ignored. I think its better to revert this and handle it outside of the PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a Typescript API that is easier to use