Devel #9
Merged
Devel #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Migrate 6 legacy test files to testthat framework - Add proper assertions for matchColumn and mmatch tests - Remove codecov badge from README - Update NEWS and .Rbuildignore - Package passes R CMD check with 0 errors, 0 warnings Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The mmatch function may return indices in different orders on different platforms (Linux vs macOS). Updated tests to compare sorted results. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Replace pragma diagnostic suppression with C99-compliant union type-punning for void* to function pointer conversions in avlTree.c - Make matchColumnIndex tests order-agnostic across platforms Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Document that the order of returned indices is consistent on Linux but has not been thoroughly tested on Windows and macOS. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The qsort function used internally is not stable, causing different ordering of equal elements on different platforms. Added explicit sorting of match indices before returning to ensure consistent ascending order on all platforms (Linux, Windows, macOS). Updated documentation to reflect guaranteed ascending order. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Remove order-agnostic helper functions since mmatch now guarantees ascending order of indices. Use direct expect_identical comparisons. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.