Skip to content

Conversation

@becoded
Copy link
Owner

@becoded becoded commented Oct 11, 2025

No description provided.

Copilot AI review requested due to automatic review settings October 11, 2025 16:23
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR performs documentation cleanup by fixing incorrect service descriptions and removing completion status indicators from the README. The main purpose is to correct misleading comments that referred to "issue related" methods when they should reference the actual service type (project, invoice, expense).

  • Corrected service documentation comments to accurately reflect their purpose
  • Simplified README by removing completion status legend and checkboxes
  • Added proper error handling for URL parsing in the API client

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
harvest/project.go Fixed service comment to reference "project related" instead of "issue related"
harvest/invoice.go Fixed service comment to reference "invoice related" instead of "issue related"
harvest/expense.go Fixed service comment to reference "expense related" instead of "issue related"
harvest/harvest.go Added error handling for URL parsing operation
README.md Removed completion status indicators and legend for cleaner documentation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

baseURL, _ := url.Parse(DefaultBaseURL)
baseURL, err := url.Parse(DefaultBaseURL)
if err != nil {
logrus.Error(err)
Copy link

Copilot AI Oct 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error handling only logs the error but continues execution with a potentially nil baseURL. Consider either panicking for this critical error or providing a fallback URL.

Suggested change
logrus.Error(err)
panic(fmt.Sprintf("failed to parse DefaultBaseURL: %v", err))

Copilot uses AI. Check for mistakes.
@codecov
Copy link

codecov bot commented Oct 11, 2025

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.84%. Comparing base (5fa70b4) to head (b3b7400).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
harvest/harvest.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
- Coverage   76.00%   75.84%   -0.17%     
==========================================
  Files          24       24              
  Lines        1542     1544       +2     
==========================================
- Hits         1172     1171       -1     
- Misses        251      253       +2     
- Partials      119      120       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants