Skip to content

Conversation

@sarff
Copy link
Contributor

@sarff sarff commented Oct 4, 2025

Double pointers in all methods

@codecov
Copy link

codecov bot commented Oct 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.00%. Comparing base (75d5ff2) to head (6cf4e0d).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
+ Coverage   69.97%   76.00%   +6.03%     
==========================================
  Files          24       24              
  Lines        1542     1542              
==========================================
+ Hits         1079     1172      +93     
+ Misses        337      251      -86     
+ Partials      126      119       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@becoded
Copy link
Owner

becoded commented Oct 4, 2025

Hello @sarff,
Thanks for your contribution!

I notice however that this is only addressed a part of the files. Would you be able to address it as well in the others?

  • harvest/client.go
  • harvest/client_contact.go
  • harvest/company.go
  • harvest/estimate.go
  • harvest/estimate_item_category.go
  • harvest/estimate_message.go
  • harvest/expense.go
  • harvest/expense_category.go
  • harvest/invoice.go
  • harvest/invoice_item_category.go
  • harvest/invoice_message.go
  • harvest/invoice_payment.go
  • harvest/project.go
  • harvest/project_task_assignment.go
  • harvest/project_user_assignment.go
  • harvest/role.go
  • harvest/task.go
  • harvest/time_entry.go
  • harvest/user.go
  • harvest/user_project_assignment.go

@sarff
Copy link
Contributor Author

sarff commented Oct 4, 2025

Done

@sarff sarff changed the title double pinter fixed double pointer fixed Oct 4, 2025
@becoded becoded merged commit 5fa70b4 into becoded:main Oct 5, 2025
8 checks passed
@becoded
Copy link
Owner

becoded commented Oct 5, 2025

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants