Attempting to fix .else #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi! We at tretton37 found a bug in the .else branch. Comparing https://github.com/becdetat/Simplicity/blob/master/src/Simplicity/PatternMatching.cs I guess I've made the right fix. But would need some tests and maybe a mention in the docs how multiple .else should work. I guess this is a breaking change, so 4.x? SemVer grumble grumble ^_^
Contributor
Author
|
If you decide this is the right path, I can help updating the README later with how .else is behaving. Oh and I didn't |
Owner
|
Nice, thank you, however it should throw an exception rather than writing to the console. I'm happier for things to break when you don't hold them correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! We at tretton37 found a bug in the .else branch. Comparing https://github.com/becdetat/Simplicity/blob/master/src/Simplicity/PatternMatching.cs I guess I've made the right fix. But would need some tests and maybe a mention in the docs how multiple .else should work.
I guess this is a breaking change, so 4.x? SemVer grumble grumble ^_^