Split InfluxDB collector into two (leave current intact and introduce a separate one for official influxdb integration)#72
Open
andrejbaran wants to merge 8 commits intobeberlei:3.xfrom
Conversation
…ial-influxdb-client # Conflicts: # src/Beberlei/Bundle/MetricsBundle/DependencyInjection/BeberleiMetricsExtension.php
lyrixx
reviewed
Mar 15, 2019
Collaborator
lyrixx
left a comment
lyrixx
left a comment
There was a problem hiding this comment.
Nice 👍 I let few comments, but it should be easy to fix.
Thanks
src/Beberlei/Bundle/MetricsBundle/DependencyInjection/BeberleiMetricsExtension.php
Outdated
Show resolved
Hide resolved
src/Beberlei/Bundle/MetricsBundle/DependencyInjection/BeberleiMetricsExtension.php
Outdated
Show resolved
Hide resolved
src/Beberlei/Bundle/MetricsBundle/DependencyInjection/BeberleiMetricsExtension.php
Outdated
Show resolved
Hide resolved
src/Beberlei/Bundle/MetricsBundle/DependencyInjection/BeberleiMetricsExtension.php
Outdated
Show resolved
Hide resolved
andrejbaran
force-pushed
the
feature/add-official-influxdb-client
branch
7 times, most recently
from
159cc8e to
9fa9028
Compare
Don't replace existing InfluxDB integration but instead add new optional one using official influxdb/influxdb-php package.
andrejbaran
force-pushed
the
feature/add-official-influxdb-client
branch
from
9fa9028 to
7f8a5e8
Compare
Author
|
@lyrixx Thanks for the quick review! ready for round 2 |
andrejbaran
force-pushed
the
feature/add-official-influxdb-client
branch
from
5ea3970 to
5fb0fb1
Compare
|
Heya @lyrixx any chance we could land this into master? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @lyrixx
here is an attempt to separate current InfluxDB integration and a new one using official package. This, if accepted, should replace #68 .
Unfortunately both packages use the same namespace
InfluxDBso the new one isn't covered by tests. Any advice how to handle it correctly?